howtowhale / dvm

Docker Version Manager
https://howtowhale.github.io/dvm/
Apache License 2.0
522 stars 50 forks source link

Use releases #110

Closed tresni closed 8 years ago

tresni commented 8 years ago

Tags appear to be limited to the last X number of valid tags (not sure what X is.) Sadly, I still need to use 1.8.3 for some systems, but it is now past the X cutoff. This allows you to use any release vs using tags

carolynvs commented 8 years ago

Thanks! I was stumped on why the old tags were dropping off :smile:

carolynvs commented 8 years ago

Looks like a more permanent fix would be to request the next page returned in the header (see doc), as even with releases instead of tags, old versions will eventually fall off the first page.

tresni commented 8 years ago

Added pagination to releases. Figured still better to use this vs tags as there are a lot of tags, but limited releases. Additionally you could eventually use the releases for download URLs in case docker ever decided they didn't want to host older releases on docker.com.

carolynvs commented 8 years ago

This is great! I just tested it out locally so once you get the page size bumped, I'll merge. :+1:

tresni commented 8 years ago

page size updated :)

carolynvs commented 8 years ago

Thank you for implementing this change! I just publish dvm 0.5.0, run dvm upgrade to get it.