Configure .bashrc/.zshrc during install script

howtowhale / dvm

Docker Version Manager

https://howtowhale.github.io/dvm/

Apache License 2.0

522 stars 50 forks source link

Configure .bashrc/.zshrc during install script #145

Closed rveguilla closed 7 years ago

rveguilla commented 7 years ago

It will be great if dvm (like nvm) took care of adding the source $HOME/.dvm/dvm.sh to .bashrc/.zshrc.

carolynvs commented 7 years ago

While I understand why this would be useful, editing people's dotfiles isn't something I want to get involved in at this time. 😃

rveguilla commented 7 years ago

I understand this is not something you probably want to invest time on right now, but I think you should seriously considered as a future enhancement. Other tools on this space (nvm, sdkman) have being doing this for a long time I will say I think it's part of the expected behavior.

ibigbug commented 7 years ago

I think keep user's rc file clean is the point. Since I don't what will nvm like tools do with which of my rc file, bashrc or zshrc? .profile or .zprofile? It's super easy to get those files mess up without a user confirm. So I don't think your point is an expected behavior, on the contrast, I think it's a bit 'dirty' work.