RuLSIF documentation and fixes

hoxo-m / densratio_py

A Python Package for Density Ratio Estimation

https://github.com/hoxo-m/densratio_py

Other

127 stars 30 forks source link

RuLSIF documentation and fixes #5

Closed ameya98 closed 5 years ago

ameya98 commented 5 years ago

Changed README to reflect the change to RuLSIF.
Returns estimated PE-divergence and KL-divergence, which is now visible in the output when printed.
Added a 2D test in test_advanced.py.
Uses len() instead of size for passed sigma_range and lambda_range to densratio(). This allows lists to be passed, instead of just numpy arrays.

coveralls commented 5 years ago

Coverage increased (+0.4%) to 96.822% when pulling acf172d5ec864ebb62df250f0caa8410641a0521 on ameya98:master into f8409c10ab1950154e1b775ce143349b41355fc5 on hoxo-m:master.

ameya98 commented 5 years ago

Changed version to 0.2 in pypi. Also, the long_description will now use the content from README. I felt this looks better. Once this is merged, publishing a new version of densratio will be great.

ameya98 commented 5 years ago

There was a missing additive factor of -1/2 in the previous computation of the alpha-relative PE-divergence. That has been fixed now.

hoxo-m commented 5 years ago

Thank you!