search

hoylabs / OpenDTU-OnBattery

Software for ESP32 to talk to Hoymiles/TSUN/Solenso Inverters, VE.Direct devices, battery management systems, and related peripherals
GNU General Public License v2.0
301 stars 63 forks source link

Fix DPL nighttime discharging: use SunPosition.isDayPeriod() to check if its day or night #1158

Closed AndreasBoehm closed 2 months ago

AndreasBoehm commented 2 months ago

I also created a PR in the upstream because it looks like there is a typo in SunPosition: https://github.com/tbnobody/OpenDTU/pull/2198

github-actions[bot] commented 1 month ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.