hoylabs / OpenDTU-OnBattery

Software for ESP32 to talk to Hoymiles/TSUN/Solenso Inverters, VE.Direct devices, battery management systems, and related peripherals
GNU General Public License v2.0
301 stars 63 forks source link

[Request] use victron battery sense if available #1227

Open spcqike opened 1 month ago

spcqike commented 1 month ago

Is your feature request related to a problem? Please describe.

as discussed here https://github.com/helgeerbe/OpenDTU-OnBattery/pull/1214#issuecomment-2329737784

Describe the solution you'd like

Wenn jemand einen SmartShunt hat und den als BatteryProvider einbindet, aber auch einen BatterySense hat, dann bevorzugen wir zur Zeit die Spannung des SmartShunt, obwohl der des BatterySense besser wäre.

it would be good to use the voltage the charger provides, if a battery sense module is connected.

so order of reliable voltage measurement would be

  1. BMS
  2. Victron solar charger if batterysense is connected
  3. smart shunt
  4. victron charger without batterysense
  5. inverter input

Darum frage ich auch zusätzlich immer erst die Batterietemperatur ab um sicher zu gehen das ein Smart Batterie Sense angeschlossen ist.

we should check whether or not a battery sense is available and use the voltages accordingly.

Describe alternatives you've considered

leave everything as it is and use the shunt voltage instead, which can be a little less accurate.

Additional context

No response