search

hoylabs / OpenDTU-OnBattery

Software for ESP32 to talk to Hoymiles/TSUN/Solenso Inverters, VE.Direct devices, battery management systems, and related peripherals
GNU General Public License v2.0
301 stars 63 forks source link

Add support for W5500 ethernet module #1231

Closed Gumbagubanga closed 3 weeks ago

Gumbagubanga commented 1 month ago

Based on the pull-request https://github.com/tbnobody/OpenDTU/pull/2068 from the upstream project, I adopted the changes to work with the newly introduced SPIPortManager.

Credits to @marvincarstensen and @LennartF22 for the implementation of the ETHSPI/W5500 support.

Tpaydt commented 1 month ago

Nice, good job

ESP32S3+W5500+NRF ist working now.

One more question. Which connection is prioritized when I start the DTU? I have now deleted the wifi settings.

Gumbagubanga commented 1 month ago

Nice, good job

ESP32S3+W5500+NRF ist working now.

One more question. Which connection is prioritized when I start the DTU? I have now deleted the wifi settings.

As before Ethernet >> Wifi.

AndreasBoehm commented 3 weeks ago

I just ordered a PoE Hat for my fusion board. Looking forward to try this PR.

schlimmchen commented 3 weeks ago

Oh nice, that means this will be taken care of, as I would need to make the time somehow, even though I have the hardware already... Thanks @AndreasBoehm.

schlimmchen commented 3 weeks ago

Thanks @Gumbagubanga :heart:

schlimmchen commented 1 week ago

There are bittersweet news regarding this PR/feature: I am going to revert these changes in favor of the upstream implementation of the SpiManager and the upstream support for W5500 Ethernet to keep the diff between this project and the upstream to a minimum.

I am kind of sorry that we lose this unique selling point. I like to think that @Gumbagubanga's effort added to Thomas motivation to merge https://github.com/tbnobody/OpenDTU/pull/2306, which replaces this feature, because earlier Versions of the W5500 support in the upstream project were not merged for a long time.

Thanks again to @Gumbagubanga and @marvincarstensen, as this feature was highly appreciated!

Gumbagubanga commented 1 week ago

There are bittersweet news regarding this PR/feature: I am going to revert these changes in favor of the upstream implementation of the SpiManager and the upstream support for W5500 Ethernet to keep the diff between this project and the upstream to a minimum.

I am kind of sorry that we lose this unique selling point. I like to think that @Gumbagubanga's effort added to Thomas motivation to merge tbnobody#2306, which replaces this feature, because earlier Versions of the W5500 support in the upstream project were not merged for a long time.

Thanks again to @Gumbagubanga and @marvincarstensen, as this feature was highly appreciated!

No hard feelings. It's just code and for the time being I can use an old version. :-) Don't forget to discard/reject my PR for the documentation project as well.

schlimmchen commented 1 week ago

No hard feelings. It's just code

And time!

Don't forget to discard/reject my PR for the documentation project as well.

Oh no, that is still relevant and valid. The upstream docs should cherry-pick it :wink: Thanks for thinking about that!