hoylabs / OpenDTU-OnBattery

Software for ESP32 to talk to Hoymiles/TSUN/Solenso Inverters, VE.Direct devices, battery management systems, and related peripherals
GNU General Public License v2.0
301 stars 63 forks source link

DTU polling interval is no longer polled after setting set. #1234

Open DanielR92 opened 1 month ago

DanielR92 commented 1 month ago

What happened?

If I set the DTU interval from 5 seconds down to 3 seconds during operation... then I no longer receive any data. If I restart the DTU, I will receive data again at shorter intervals than set.

To Reproduce Bug

After a restart, you setup the settings to a new value. The issue will come bag.

Expected Behavior

After setting the value, the new legal time should be recognized as the maximum.

Install Method

Pre-Compiled binary from GitHub

What git-hash/version of OpenDTU?

gad493c0

Relevant log/trace output

No response

Anything else?

No response

Please confirm the following

schlimmchen commented 1 month ago

I cannot recall that this ever happened to me, and from looking at the code for 20 min I am confused as to how this could happen at all. I had hoped for an easy explanation.

@spcqike @manos1966 can you guys reproduce this?

Manos1966 commented 1 month ago

Ich werde es morgen testen (ich habe das DTU interval seit 2023 nicht angefasst 😜 )

spcqike commented 1 month ago

I can’t. Changing from 1 to 3 to 2 seconds, everything works as expected without reboot.

Manos1966 commented 1 month ago

git-hash/version of OpenDTU = gad493c0

Welche Version ist diese? Eine ältere?

DanielR92 commented 1 month ago

grafik

Das müsste dieser hier sein: https://github.com/helgeerbe/OpenDTU-OnBattery/actions/runs/10652874817?pr=1216

Manos1966 commented 1 month ago

Aha! Dann macht es also Sinn, warum unsere offizielle Versionen dieses Problem nicht haben.

DanielR92 commented 1 month ago

Ja @schlimmchen hat nach Testern aufgerufen und nun bin ich hier. :) PS: Wenn ich in openDTU in der Systemseite den git-Hash anklicke, leitet es mich hierhin weiter... https://github.com/helgeerbe/OpenDTU-OnBattery/releases/tag/gad493c0

Aber diese Seite existiert nicht mehr.

DanielR92 commented 1 month ago

I can’t. Changing from 1 to 3 to 2 seconds, everything works as expected without reboot.

You don't understand me correctly, in my version what I have. It is necessary to reboot manually to work with the new settings.

schlimmchen commented 1 month ago

Aber diese Seite existiert nicht mehr.

@DanielR92 Das hat damit zu tun, dass ich den commit weggebügelt habe mit einem force push. Damit musst du bitte leben, dass das passieren kann, wenn du Vorabversionen aus Pull Requests installierst.

@spcqike @Manos1966 Thanks for looking into it! Lets keep an eye on it, but it seems this is a fluke. Daniel has multiple of those, but they are real, he showed me by sharing his screen using discord, so there should be something to it...

DanielR92 commented 4 weeks ago

@schlimmchen Hab doch nichts dagegen gesagt... ;)

schlimmchen commented 4 weeks ago

Yesterday I compared the sources of lib/Hoymiles/ and src/WebApi_dtu.cpp between this project and the upstream, but could not find anything unexpected or wrong.