search

hoylabs / OpenDTU-OnBattery

Software for ESP32 to talk to Hoymiles/TSUN/Solenso Inverters, VE.Direct devices, battery management systems, and related peripherals
GNU General Public License v2.0
301 stars 63 forks source link

Implement receiving of CAN messages via MQTT #1279

Open ranma opened 2 weeks ago

ranma commented 2 weeks ago

This is mainly intended for debugging.

image

schlimmchen commented 2 weeks ago

This is mainly intended for debugging.

I like it, it is elegant. Nice :muscle: However, if it is really just for debugging or development, should we guard it with a #define? Unfortunately, transmitting this info to the web app will be cumbersome. @AndreasBoehm What do you think? Can this be a mainstream feature? I guess there should be a prominent warning that "this setting is probably not for you" (plus link to the docs)?

AndreasBoehm commented 1 week ago

What if we put it in the web app but don't include it in the navigation? A 'dev menu' that is only accessible if you know the URL/path?

EDIT: or we add a URL param dev=true ?

ranma commented 1 week ago

EDIT: or we add a URL param dev=true ?

Changed the view so it only shows up with ?debug=true.