hoyois / clicktoplugin

Prevents plug-ins from loading automatically in Safari
http://hoyois.github.com/safariextensions/clicktoplugin/
228 stars 44 forks source link

"Download" menu item not working (Safari 10 issue?) #176

Open ballo opened 7 years ago

ballo commented 7 years ago

The "Download Video" popup menu option makes the URL bar flash for a fraction of a second (can't read it) but it doesn't download the video. I can PLAY the video so I'm assuming the links still work, but the download fails with no error or item in the list.

I restarted my browser but this is still an issue. This was working yesterday, but now it fails for whatever reason.

I can manually right-click the 720p link, copy, and paste in a new window but this work-around is cumbersome.

Test video:

https://www.youtube.com/watch?v=mGjdCrq8In8

ballo commented 7 years ago

I can't reliably reproduce this anymore.

I also found a better work-around of simply dragging the 720 link to the url bar

ballo commented 7 years ago

Safari 10 has a lot of issues with click2plugin.

The download link now plays in the browser half the time. The work-around doesn't work.

Previous Safari the download link would work instantly. In Safari 10 you have to wait for it to load, and half the time it won't download but instead play. Forcing a download (option-return) causes the filename to be generic which makes the plugin useless for downloading a bunch of videos.

Bwass commented 7 years ago

I'm having the same problem, Safari 10, El Capitan 10.11.6. Seems to be related to the last major Safari update. I've heard that Safari 10 had some major overhaul of how it manages audio/video content. Could be related to the use of new frameworks for multimedia.

When I choose "Download Video", the link to the video is followed correctly in the same tab, video plays using the QuickTime plugin. File can be downloaded, either by doing option-return in the URL field, or by using the contextual menu from the video frame, but it receives the generic "videoplayback.mp4" name. Previously, the title of the video was automatically attributed to the saved file, followed by the resolution, e.g. "[720p]".

Note that the video title is included in the URL generated by this method. The parameter is "title" and is properly URL-encoded. There's also a parameter called "mime" set to "video/mp4".

ballo commented 7 years ago

It seems to happen with some videos and not others. When it happens I have to download the video then rename it which is a major PITA when downloading 30 or so videos at a time.

I'm disappointed to hear that Safari had a major AV overhaul considering it still SUUUUCKS. I have to be careful not to let the video play past the downloaded section or else it will go into that ultra annoying download-a-piece-at-a-time mode which causes the RealVideo-esque buffering nonsense. What's worse, the new version of quicktime now behaves in the same manner so the only way to avoid it completely is to download EVERYTHING!

I honestly don't understand what the hell Apple is trying to do. I honestly only use Safari because it supports click2plugin and keychain (plus I'm trying to avoid Google like the plague since they have gone Full Evil™)

ballo commented 7 years ago

Update: I think the issue may be related to different video formats which are becoming more prevalent. When I have this issue I end up using the command youtube-dl (installed via brew) which works fine. youtube-dl also allows you to download the 1080p video and marge it with the audio.