search

hoyois / clicktoplugin

Prevents plug-ins from loading automatically in Safari
http://hoyois.github.com/safariextensions/clicktoplugin/
229 stars 43 forks source link

HTML5 default player loading again on youtube.com/watch pages #93

Closed ghost closed 10 years ago

ghost commented 10 years ago

I use Safari 7.1 on Mavericks 10.9.5 and have noticed since yesterday (I believe) that CTP is being replaced again by the default HTML5 player with ads on YouTube. I use CTP 2.9.9 which has been working perfectly since Marc fixed it about a month ago. /user pages work as usual. Has Google decided to start a cat and mouse game with us?

fatherkanye commented 10 years ago

Same has happened to me on Yosemite and a few others in the previous thread, waiting for a reply from Marc. I think it has something to do with a recent YouTube update

ghost commented 10 years ago

Is this really the same issue? I've never seen the black div mentioned in the other thread. But it sure might come from the same Google update.

fatherkanye commented 10 years ago

Well for me sometimes I get a black box instead of the usual html5 player and sometimes the built in YT player loads with ads

ghost commented 10 years ago

Personally I see CTP loading as usual but quickly being replaced by the default player. Which is what makes me think Google knows what we're up to and does not agree. I'll try to look at their code and see if I can find something. All I can say for the moment is that the Firefox port of CTP I've been working on and talking about to Marc is still working.

fatherkanye commented 10 years ago

I see the same thing before the default player loads. I agree that YT must realise that CTP cuts off a significant amount of ad revenue and is working around it.

hoyois commented 10 years ago

@mm2703 Google couldn't care less about what we're doing, really. What you describe is what has always happened on YouTube in Safari <8 if you don't have Flash: the page loads with a Flash object in it which is then replaced by an HTML5 player. The YouTube.js killer contains a minimal hack to prevent this from happening, but this hack obviously depends on how YouTube's scripts work so it breaks every now and then. Clearly that hack has stopped working for you. Unfortunately it still works for me, so I can't debug the issue myself.

What does ytplayer.config return on a /watch page?

ghost commented 10 years ago

A pretty huge object I'm not sure I can paste for privacy reasons. What are the properties you'd need to debug?

Glad to know you're confident in the future of CTP, do you say this because we're not a great deal of users?

hoyois commented 10 years ago

OK, at least that object exists. Here's what mine looks like, do you see any obvious differences?

screen shot 2014-11-15 at 10 50 49

Glad to know you're confident in the future of CTP, do you say this because we're not a great deal of users?

A negligible amount, yes, but that's not the only reason.

ghost commented 10 years ago

Mine is actually not instantiated. I'm not a JS expert but I guess the values I was afraid of pasting here were actually the default values (I hadn't noticed they're under the __proto__ node).

Could you give us those other reasons or do you think it's not appropriate here?

hoyois commented 10 years ago

That's a significant difference. Are you using any other extension that might interfere with YouTube's scripts?

Could you give us those other reasons or do you think it's not appropriate here?

It's pretty simple: Google openly provides URLs to all YouTube videos. They wouldn't if they wanted to prevent 3rd-party software from using them.

ghost commented 10 years ago

Geez, I'm sorry, I didn't even think to look at my other extensions. AdBlock must have been updated in the last days because when I disable it everything's working properly.

hoyois commented 10 years ago

Is it possible to configure Adblock not to mess with YouTube?

ghost commented 10 years ago

I've been trying to disable some and then all filters but it still produced the issue. It only works with the extension fully disabled. It's strange.