search

hoyon / mpv-mpris

MPRIS plugin for mpv
MIT License
608 stars 35 forks source link

expose musicbrainz metadata if available #79

Closed tpeacock19 closed 2 years ago

tpeacock19 commented 2 years ago

I took a stab at exposing some musicbrainz metadata if it is present in mpv. This will be useful for anyone who has tagged their music library with Musicbrainz Picard and could be used in some scrobbling programs.

tpeacock19 commented 2 years ago

Actually i need to update a bit more with this. I want to cover all the default separator options in Musicbrainz Picard. Which gives the options / ; and /(with space surrounding).

tpeacock19 commented 2 years ago

Actually, now that I review this I believe that the metadata should not be separated. That would be a job for any program consuming this data. There should be a single value for the Musicbrainz Album/Artist/etc. Id, also including any potential separators. This would make this PR much simpler. If you agree I'll force push some reversions.

hoyon commented 2 years ago

Yeah I think that makes sense. To be honest I'm not very familiar with music brainz so if you think that makes sense let's do it!

tpeacock19 commented 2 years ago

Okay I've got a bit more to work on this. Will let you know when it's ready.

tpeacock19 commented 2 years ago

Ah apologies for not letting you know but this has been working for me for about a month. Thanks for merging.