[WIP] Add domain routing support

hozana / next-translate-routes

Flexible and translated routes for Next.js without custom server

MIT License

115 stars 30 forks source link

[WIP] Add domain routing support #65

Open cvolant opened 1 year ago

cvolant commented 1 year ago

The current changes seem to work but don't.

In the example, the api docs link is broken:

In fr, it is not translated correctly when multi domain is configured
In en, a clic creates a looping redirection event when multi domain is not configured

nicrodgers commented 1 year ago

I've yet to give this a proper test but will do so over the next few days, as we have a requirement to use domain based routing with translated paths. Have you been using it with any success? One tiny thing I noticed, is that the README will need to be updated to remove domain routing from the list of unsupported features.

nicrodgers commented 1 year ago

This does seem to work well with Next 12. It doesn't work with next 13, but then the main next-translate-routes package says it's not yet next13 compatible, so that makes sense... Will do more testing over the next few days...