hozana / next-translate-routes

Flexible and translated routes for Next.js without custom server
MIT License
115 stars 30 forks source link

[WIP] Support for fallbackLng (substituable language) #66

Closed michalpulpan closed 1 year ago

michalpulpan commented 1 year ago

This PR tries to implement logic supporting fallbackLng object in the i18n config (more described in the #58). The requirement was basically to implement:

{
   locales: ['fr', 'fr-FR', 'fr-BE', 'en', 'es', 'pt'],
   fallbackLng: {
    'fr-FR': ['fr'],
    'fr-BE': ['fr'],
   }
}

So that we don't have to store redundant data in our _routes.json and be fully compactible with i18n-next fallbackLng.

It implements a function getPathFromPaths (sorry for this naming getPath is already used plugin/getRouteBranchReRoutes.ts 👀 ). It was necessary to extend types.ts a bit with (fallbackLng object in TNtrData) and to create custom NTRI18NConfig extending original I18NConfig.

With this we should be now able to resolve the logic described above.

❗ But, this doesn't (yet) implement logic of nonExplicitSupportedLngs and it could still raise warning of Max custom routes reached. I'm currently not 100% sure how to implement it so we could do different PR for it?.

All previous test cases pass and since we have to use different defaultNtrData in test cases (due to fallbackLng dict ) I added setEnvDataFallbackLng function with which we have to run before fallbackLng is tested (or it's presence). Hope it's clear and okay like this. It's a lot of redundant test but I did not workout how to make basically test it more intelligently without ruining previous tests (and adding fallbackLng everywhere).

Thank you for your feedback @cvolant !

cvolant commented 1 year ago

Hi @michalpulpan! Any news on this?

michalpulpan commented 1 year ago

Hi @michalpulpan! Any news on this?

Hi, I'm sorry, I completely forgot about this 🤦 . I'll do it ASAP!

Oh, and I don't understand why the yarn.lock has changed. Maybe we don't have the same node version or something.

I din't notice it. Do you think I should restore it to the version in a main branch? 🤔

michalpulpan commented 1 year ago

@cvolant Pushed proposed fixes. 😊 Please let me know how to deal with the yarn.lock. Otherwise I'm ready!

cvolant commented 1 year ago

Hi @michalpulpan, thank you for the update, and sorry for the delay, I was off for some days.

To solve the yarn.lock, you can try: git checkout master -- yarn.lock.

Then I will merge it and release a new version.

michalpulpan commented 1 year ago

Hi @michalpulpan, thank you for the update, and sorry for the delay, I was off for some days.

To solve the yarn.lock, you can try: git checkout master -- yarn.lock.

Then I will merge it and release a new version.

Hi, no problem 😊. Thank you for the trick, hopefully it worked out and yarn.lock is merged from master