search

hozn / coilmq

Lightweight Python STOMP message broker.
Apache License 2.0
49 stars 18 forks source link

CI builds are no longer running #31

Open ejd opened 3 years ago

ejd commented 3 years ago

Would you be interested in a PR that fixes CI for coilmq?

CI builds are not running anymore because this project (as far as I can tell) isn't yet configured to have CI run on travis-ci.com. travis-ci.org no longer does builds.

Unfortunately, the builds would fail even if they were running on the new travis-ci site. I forked coilmq to work on #29 and enabled travis-ci for the fork. My results look pretty much the same as when CI ran most recently against your repo for #28.

Pinning the fakeredis dependency to an earlier version may fix the problem with the python 2.7 build failures. Or, it may require listing a package multiple times in one of the requirements files and adding different environment markers to each. For example, fakeredis < X.Y.Z; python_version <= '2.7' and fakeredis >= X.Y.Z; python_version > '2.7'. If a quick fix like these can't be made to work, I could set you up with tox -- a little more involved but, IMHO, very worthwhile.

hozn commented 3 years ago

@ejd , sure, I'd love it! Also, I'd probably get rid of python 2.x support if I were looking at this code again.

Do you want me to just make you a maintainer?

ejd commented 3 years ago

I agree that it makes sense to drop Python 2.x support. I'm looking forward to helping out!

hozn commented 3 years ago

Thanks so much, Eric. I love that someone has taken interest in this science project :). Feel free to take this in whatever direction you think makes sense.