search

hparra / gulp-rename

Rename files easily
MIT License
692 stars 73 forks source link

Clean up Gulpfile, and update dependencies #41

Closed SimenB closed 9 years ago

SimenB commented 9 years ago

Hi!

This is just cleaning up the FIXMEs in the gulpfile, as well as bumping all dependencies. I introduced gulp-mocha as well.

I also fixed the linting errors, and made the linting run as part of the testing.

SimenB commented 9 years ago

I'm aware of #9 and #10, but after you merged #36 none of the extra files are installed to the end user, so it shouldn't be a problem

shinnn commented 9 years ago

none of the extra files are installed to the end user, so it shouldn't be a problem

No. #9 and #10 are still open issues because we want to simplify this repository. The package file size doesn't matter.

SimenB commented 9 years ago

none of the extra files are installed to the end user, so it shouldn't be a problem

No. #9 and #10 are still open issues because we want to simplify this repository. The package file size doesn't matter.

Do you want me to delete the gulpfile and call jshint and mocha manually? I won't touch the fact that gulp is used in the tests, but #9 at least is a low hanging fruit.

EDIT: #43 Is the same as this, without changes to .gitignore, and removing the gulpfile

shinnn commented 9 years ago

43