search

hpc-carpentry / hpc-carpentry.github.io

The HPC Carpentry website
http://www.hpc-carpentry.org/
MIT License
4 stars 7 forks source link

restore HPC content, remove Carpentries content #22

Closed tkphd closed 3 years ago

tkphd commented 3 years ago

This PR aims to remove material specific to The Carpentries, such as institutional sponsors and donation opportunities, and replace boilerplate or Carpentries-specific copy with HPC Carpentry equivalents.

The table enumerating HPC Carpentry lessons has been restored.

The Help Wanted page has been filtered to only show issues from HPC Carpentry lessons.

tkphd commented 3 years ago

Thank you for the feedback, @reid-a and @ocaisa. Before responding to the individual comments, I want to summarize my mindset when I made these sweeping, often deep-cutting, changes.

HPC Carpentry is a nascent organization, and we aspire to join The Carpentries. It remains to be seen whether that will occur, and if it does, on what timeline. With that in mind:

  1. The repository this one is based upon is CC BY, so we can copy all of it.
  2. The upstream repository is actively maintained by a larger organization, and subject to change -- often for the better -- that we can synchronize with as needed.
  3. When deploying the site to represent ourselves, it is important that we do not misrepresent HPC Carpentry as a formal member of The Carpentries.
  4. Parts of the upstream website interface with AMY, where contributors opt in to be publicly listed. That permission is granted to The Carpentries, not to HPC Carpentry. It is unethical to include those parts.
  5. We are a small team, and each additional line of code represents a maintenance burden.
  6. If a feature, page, or parameter is of immediate use, it stays.
  7. If a feature, page, or parameter might come in handy -- let the upstream maintainers improve those parts and, when the time comes for us to include them, we can pull the latest versions.
reid-a commented 3 years ago

I think I concur with @tkphd that, when we become official, we'll want to match up with the then-current Carpentries scheme, which may not match the material that's been removed here. FWIW.

tkphd commented 3 years ago

Valid points, @ocaisa, thank you for the patient replies. I will revise.

tkphd commented 3 years ago

For fellow travelers, the back-and-forth between @ocaisa (who originally ported this website, and is the expert) and myself (not a Jekyll noob either) is a healthy exchange, and at the end, we'll have a better website for it. This is why we have pull requests and peer review, rather than making changes to the production website directly. Plus, it looks like this has spurred some awesome upgrades -- much appreciated, Alan!

tkphd commented 3 years ago

OK, @ocaisa! I've done my best to resolve your detailed comments & objections. Site build locally, and now displays our shared Google Calendar and presents @megan-guidry as our Regional Coordinator for New Zealand. Let me know what you think.

ocaisa commented 3 years ago

This is great, thanks a lot for spending so much time on it @tkphd !

tkphd commented 3 years ago

Of course, @ocaisa -- happy to do my part!