hpc-social / hpc-social.github.io

Portal for the HPC Social community ⭐️
https://hpc.social
Other
16 stars 4 forks source link

updating mastodon links and page #39

Closed vsoch closed 1 year ago

vsoch commented 1 year ago

This will address a few issues:

The user flow (for someone that comes to the site looking to join Mastodon) could be either of the following:

Signed-off-by: vsoch vsoch@users.noreply.github.com

netlify[bot] commented 1 year ago

Deploy Preview for hpc-social ready!

Name Link
Latest commit 19ef57ccfcd56fe9622a087f6cb61e0fee286414
Latest deploy log https://app.netlify.com/sites/hpc-social/deploys/63829fd35a94f30008c9104f
Deploy Preview https://deploy-preview-39--hpc-social.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vsoch commented 1 year ago

New icon isn't rendering in preview - taking a look.

vsoch commented 1 year ago

okay I see the issues - going to push a fix.

vsoch commented 1 year ago

Previews:

image image

alansill commented 1 year ago

Previews in the PR look good. Out of curiosity, why doesn't the icon show up in the Netlify preview after the fix that made it work in the posted previews?

vsoch commented 1 year ago

The reason it didn't work for the first push was because the URL to provide the icon from the hpc.social domain doesn't exist yet. The fix uses a hard slash that will honor whatever root domain is provided (including the preview site). This should always work for the site here, and only will have issue if this template is moved to a subdomain site (e.g., like the map).

vsoch commented 1 year ago

Yeah! That's why I wanted to get Netlify previews up quickly - they make reviewing webby stuff really easy (and you don't necessarily need to look at the messy code if you know where on the site to look). I really love Netlify - I wish their free tier was larger I'd use it all over the place. We only get 300 builds / month.

Now that I think of it - when we merge, we are using up build time. I think what we will need to do moving forward is adding a [skip ci] to every PR as a squash and merge in the message, and that way it will skip. See https://answers.netlify.com/t/support-guide-how-can-i-optimize-my-netlify-build-time/3907/5 I can't find any global way to disable building the production branch.