Remove `lib` prefix check from spindle stat

hpc / Spindle

Scalable dynamic library and python loading in HPC environments

Other

94 stars 22 forks source link

Remove `lib` prefix check from spindle stat #33

Closed jjhursey closed 4 years ago

jjhursey commented 4 years ago

With this in place mkdir and stat on directories and non-DSO files will fail. Encountered when working with a libcoll_cache directory.

jjhursey commented 4 years ago

Thanks @sam6258 for finding and fixing this issue.

jjhursey commented 4 years ago

An alternative to this would be to adjust is_lib_prefix to:

Check for lib prefix, and
Check that the fname is a file, and
Check that the fname is suffixed with either .so or .a

I don't know if that is too heavyweight for this check or not.

mplegendre commented 4 years ago

This got fixed in the last release by adding the .so suffix test--I also hit the libcoll_cache issue. On more consideration, we could be even safer by checking on file read that the lib.so is really a DSO, and canceling the broadcast if not. I'll open a new issue for that.

mplegendre commented 4 years ago

https://github.com/hpc/Spindle/commit/22871945557038ba375c8f1eea1f20d090ee723d -- the fix

jjhursey commented 4 years ago

Perfect. Thanks. I didn't notice that.