hpc / Spindle

Scalable dynamic library and python loading in HPC environments
Other
94 stars 22 forks source link

flux plugin build and install broken #53

Open grondo opened 1 month ago

grondo commented 1 month ago

It appears that in c3ef9a2f242b36808da92e2ef613bb80299e6f4f some of the autotools setup for the Spindle Flux plugin was removed.

Unfortunately, this breaks proper (or perhaps more correctly _convenient) installation of the Flux plugin. Things that would help the install of the flux plugin include:

I'm also not seeing any checks for libflux-core.so and libflux-hostlist.so, but I must be missing this because the flux plugin is built with these libs and FLUX_CORE_LIBS and FLUX_CORE_CFLAGS etc are defined in the Makefiles, so I apologize if I missed something obvious.

mplegendre commented 1 month ago

I'm cautious about going to spindle.so for the flux plugin. Spindle already has a libspindle.so for its user interface library, and mixing those names could be confusing. Could we symlink a spindle.so in the flux plugin space to a libspindleflux.so in the spindle space?

Will investigate the pluginpath issue.

grondo commented 1 month ago

Eh, like I said the naming isn't critical, by default the Flux job shell will load *.so from the plugin search path, so either fluxspindle.so or libfluxspindle.so would work.