search

hpc / charliecloud

Lightweight user-defined software stacks for high-performance computing.
https://hpc.github.io/charliecloud
Apache License 2.0
308 stars 61 forks source link

tidy: fix W0221 arguments-differ #1877

Open reidpr opened 3 months ago

reidpr commented 3 months ago

Split from #1860. Pylint: W0221 arguments-differ

For example, superclass:

https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build.py#L293 https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build.py#L439

Subclass:

https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build.py#L616 https://github.com/hpc/charliecloud/blob/d67937332094a7d8de8e9bd2e112d30d117c50c0/lib/build.py#L634-L635

This violates Liskov substitution principle and should be fixed.