search

hpc / ior

IOR and mdtest
Other
377 stars 166 forks source link

ior/mdtest should include a git hash in their output #132

Closed glennklockwood closed 4 years ago

glennklockwood commented 5 years ago

We should bake a git commit hash into every formal build of IOR/mdtest that is reported (probably through a verbose option) to help users determine exactly what version of IOR/mdtest they are using. This would help simplify debugging issues for users who check out IOR/mdtest directly from the repository rather than download a packaged source distribution.

johnbent commented 5 years ago

I would suggest to include it in all output regardless of verbose to make sure we always knew which version created a particular output. That would have helped with this recent situation where some people (including myself) weren't aware just by looking at output whether it was run before or after the mdtest/stonewall bug fix.

On Thu, Feb 7, 2019 at 1:14 PM Glenn K. Lockwood notifications@github.com wrote:

We should bake a git commit hash into every formal build of IOR/mdtest that is reported (probably through a verbose option) to help users determine exactly what version of IOR/mdtest they are using. This would help simplify debugging issues for users who check out IOR/mdtest directly from the repository rather than download a packaged source distribution.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hpc/ior/issues/132, or mute the thread https://github.com/notifications/unsubscribe-auth/AB89Pp0X708IWgrAC3JGpMDFemawb66uks5vLIkhgaJpZM4apNWA .

hjelmn commented 5 years ago

Agreed. autogen should do this. That way it is in every tarball.

JulianKunkel commented 5 years ago

Autogen would be very unreliable as it may be missed when checking out another version. That seems to be the way using the ident Attribute: https://git-scm.com/docs/gitattributes

Am Do., 7. Feb. 2019, 20:43 hat Nathan Hjelm notifications@github.com geschrieben:

Agreed. autogen should do this. That way or is every tarball.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hpc/ior/issues/132#issuecomment-461588463, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1uymMrd2TYASEeXee-Gng_6aH2R2hDks5vLJAIgaJpZM4apNWA .

JulianKunkel commented 4 years ago

I believe this is unreliable as people can change the code. Using the info from META as we do right now is better suited as long as we update META more frequently. I close this issue, if someone wants to work on it, please reopen it.