search

hpc / mpifileutils

File utilities designed for scalability and performance.
https://hpc.github.io/mpifileutils
BSD 3-Clause "New" or "Revised" License
169 stars 68 forks source link

libarchive: update to version 3.5.1 #436

Closed daltonbohning closed 3 years ago

daltonbohning commented 3 years ago

libarchive 3.5.1 fixes some compile issues from 3.5.0. I suggest using 3.5.1 in the documentation, etc. so other users don't run into compile issues that are fixed in 3.5.1.

Signed-off-by: Dalton Bohning daltonx.bohning@intel.com

adammoody commented 3 years ago

Thanks, @daltonbohning . Let's go ahead and bump everything to 3.5.1.

Would you mind updating travis and the docs to use 3.5.1 as part of this PR?

daltonbohning commented 3 years ago

Thanks, @daltonbohning . Let's go ahead and bump everything to 3.5.1.

Would you mind updating travis and the docs to use 3.5.1 as part of this PR?

@adammoody I believe this PR does contain all of the necessary changes for 3.5.1

Also, it seems that: https://github.com/hpc/mpifileutils/blob/a7afd70adc8807b5ce180823d5847497e41db9a6/CMakeLists.txt#L87 Does not enforce the version. From https://cmake.org/cmake/help/latest/command/find_package.html "CMake searches for a file called Find<PackageName>.cmake ... It is responsible for finding the package, checking the version, and producing any needed messages."

For example, I did this locally: FIND_PACKAGE(LibArchive 3.5.0 REQUIRED) And cmake accepted it: -- Found LibArchive: <path>/libarchive.so (Required is at least version "4.0")

I'm not familiar enough with cmake to know how to enforce the version in FindLibarchive.cmake, but maybe this is okay, since the documentation directs users to use 3.5.1

daltonbohning commented 3 years ago

@adammoody Also, for what it's worth, yum install libarchive doesn't have an rpm for 3.5.0+ on all distributions, so not enforcing the version could actually be beneficial to users who don't need the improvements, because it means that yum install libarchive, etc. (which gives version < 3.5 on some systems) would be sufficient for a compile.

This would actually be beneficial to us for DAOS, since we aren't currently using any utilities that absolutely require this updated version.

adammoody commented 3 years ago

Oh, right. I skimmed things too quickly the first time through. And I also agree with your point about not making the newer libarchive be a strict requirement. This all looks good to merge. Thanks again.

daltonbohning commented 3 years ago

No worries. Thanks!