search

hpc / mpifileutils

File utilities designed for scalability and performance.
https://hpc.github.io/mpifileutils
BSD 3-Clause "New" or "Revised" License
169 stars 68 forks source link

serialize and deserialize almost all props #460

Closed daltonbohning closed 3 years ago

daltonbohning commented 3 years ago

@dsikich I didn't see any logic for deserializing the properties. Maybe I overlooked that somewhere?

dsikich commented 3 years ago

@daltonbohning right now I am deserializing the cont layout and the version. Deserializing is quite a bit simpler. You can find the cont layout deserialization in cont_deserialize_hdlr.

dsikich commented 3 years ago

@daltonbohning The properties get set when the container is created

daltonbohning commented 3 years ago

cont_deserialize_hdlr

@dsikich Not sure how I missed that before... I'll add in the rest of the deserialization. Thanks!

daltonbohning commented 3 years ago

@dsikich I added the deserialization, but I wasn't able to properly test because of the container create issue we talked about before. Also, we could probably simplify the serialization and deserialization of the properties by just looping over each property and using a case statement to decide whether to use str, uint or opaque. Maybe we can think about that once it is functionally working.