daos: use internal IO functions

hpc / mpifileutils

File utilities designed for scalability and performance.

https://hpc.github.io/mpifileutils

BSD 3-Clause "New" or "Revised" License

169 stars 68 forks source link

daos: use internal IO functions #472

Closed daltonbohning closed 3 years ago

daltonbohning commented 3 years ago

Replace the dfs_ IO calls with the new dfssys API.
Return ENOSYS when not DAOS_SUPPORT.
Added mfuerrno2rc to simplify returns from dfs* calls.

Signed-off-by: Dalton Bohning daltonx.bohning@intel.com

dsikich commented 3 years ago

@daltonbohning this looks ok to me. Most of it looks like it is just replacing the daos versions of the io functions with the dfs_sys library version in DAOS. Are all of the tests passing with this version?

daltonbohning commented 3 years ago

@daltonbohning this looks ok to me. Most of it looks like it is just replacing the daos versions of the io functions with the dfs_sys library version in DAOS. Are all of the tests passing with this version?

@dsikich Almost, with a few edge-case exceptions that will be handled internally (patch in review in DAOS).

daltonbohning commented 3 years ago

@adammoody This is working and ready for review now.

daltonbohning commented 3 years ago

Thanks @daltonbohning and @dsikich . Wow, that cleans up a ton of code! That's really nice. It's also somehow sad to see all of that first draft of the code go away, though, knowing the effort you two put into it. Thanks! Looks good to me.

Thanks @adammoody ! We actually took this draft of the IO functions and created an new API out of them that can be re-used in other applications, so it wasn't a waste!