hpc / mpifileutils

File utilities designed for scalability and performance.
https://hpc.github.io/mpifileutils
BSD 3-Clause "New" or "Revised" License
164 stars 64 forks source link

serialization optimizations for DAOS_OF_KV_FLAT #482

Closed dsikich closed 3 years ago

dsikich commented 3 years ago
* add daos-gen tool to generate a DAOS_OF_KV_FLAT objects
* skip akey iteration on serialize and deserialize for DAOS_OF_KV_FLAT

If an object has the DAOS_OF_KV_FLAT feature set, then there is no need to do any sort of akey iteration. The daos_kv API is used because all that is needed is oid, dkey, and the value. The obj API and the daos_kv API cannot be mixed, or it will cause errors. The KV value is stored inside of the dkey dataset.

Signed-off-by: Danielle Sikich danielle.sikich@intel.com

dsikich commented 3 years ago

@daltonbohning @adammoody should not be merged before #477

adammoody commented 3 years ago

This generally looks good to me. Of course, I can't do any runtime testing, so that limits how deeply I can review things. Just a few high-level things I saw:

dsikich commented 3 years ago

@daltonbohning @adammoody addressed the comments and broke up one of the deserialization functions

dsikich commented 3 years ago

@daltonbohning I've updated based on your review, thanks.

dsikich commented 3 years ago

@adammoody is this good to merge now?

adammoody commented 3 years ago

Yep, looks good to me, too. Thanks, @dsikich