Closed dsikich closed 3 years ago
@daltonbohning @adammoody should not be merged before #477
This generally looks good to me. Of course, I can't do any runtime testing, so that limits how deeply I can review things. Just a few high-level things I saw:
char foo[size]
where size
is computed at runtime. I think those probably need to use a malloc(size)/free()
instead in some cases.@daltonbohning @adammoody addressed the comments and broke up one of the deserialization functions
@daltonbohning I've updated based on your review, thanks.
@adammoody is this good to merge now?
Yep, looks good to me, too. Thanks, @dsikich
If an object has the DAOS_OF_KV_FLAT feature set, then there is no need to do any sort of akey iteration. The daos_kv API is used because all that is needed is oid, dkey, and the value. The obj API and the daos_kv API cannot be mixed, or it will cause errors. The KV value is stored inside of the dkey dataset.
Signed-off-by: Danielle Sikich danielle.sikich@intel.com