search

hpc / mpifileutils

File utilities designed for scalability and performance.
https://hpc.github.io/mpifileutils
BSD 3-Clause "New" or "Revised" License
168 stars 66 forks source link

daos: serialize new props and check cont status property #492

Closed dsikich closed 3 years ago

dsikich commented 3 years ago

Check DAOS_PROP_CO_STATUS and do not serialize or copy properties if status is unhealthy. Add force option to serialize even if status is unhealthy, but never copy with unhealthy status.

Serialize DAOS_PROP_CO_ROOTS and DAOS_PROP_CO_EC_CELL_SZ, which were added after initial implementaion of daos-serialize was completed. Also, remove calling of dfs_cont_create in deserialization to avoid serialized properties being overwritten. Since DFS API is not used in serialization or deserialization it is better to instead use daos_cont_create and pass in preserved properties to the deserialization.

Signed-off-by: Danielle Sikich danielle.sikich@intel.com

dsikich commented 3 years ago

@dsikich Just FYI, I didn't run any of our functional tests against this branch.

@daltonbohning so far I just tested copies and serializations manually because I had an issue running functional tests locally recently, but I found a workaround in one of the channels to try. I will try that and then run serialization and dcp ones.

dsikich commented 3 years ago

@daltonbohning @adammoody merging this I just needed to rebase into one commit, functional tests in DAOS were ran on dcp and the serialization tools for verification as well.

daltonbohning commented 3 years ago

@daltonbohning @adammoody merging this I just needed to rebase into one commit, functional tests in DAOS were ran on dcp and the serialization tools for verification as well.

@dsikich What you can also do when merging is "Squash and merge". It's confusing, because "Squash and merge" doesn't actually merge, it rebases! It does this:

  1. Squash all commits into one commit
  2. Push that commit to master (basically rebase, so no merge commits)