search

hpc / mpifileutils

File utilities designed for scalability and performance.
https://hpc.github.io/mpifileutils
BSD 3-Clause "New" or "Revised" License
170 stars 68 forks source link

Export of inconsistent internal headers #549

Open drabmart opened 1 year ago

drabmart commented 1 year ago

The header file mfu_flist_internal.h gets installed (distributed) with the compiled library. (Is this intentional? Why is it called "internal" then?) Anyway, unfortunatelly it is being included by the utils/tools/h5dwalk/h5dwalk.c file (from the HDF5 1.14 project). However, mfu_flist_internal.h unconditionally includes strmap.h, which is not being installed. And that is an error. Either both or none of them should be installed (distributed). If the functions/structures in the mfu_flist_internal.h are supposed to be used externally (like apparently they are in HDF5), then strmap.h has to be installed (distributed) too.

adammoody commented 1 year ago

Yes, good point. Thanks for the report, @drabmart . The original intent was not to distribute internal headers, but then we did so since it made it easier for others to develop new tools using the libmfu library. I think including strmap.h was then overlooked. I'll take a look.