search

hpc / mpifileutils

File utilities designed for scalability and performance.
https://hpc.github.io/mpifileutils
BSD 3-Clause "New" or "Revised" License
167 stars 64 forks source link

rpm: use %cmake macros #564

Closed rezib closed 10 months ago

rezib commented 11 months ago

Documentation about these macros is available in Fedora project packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/

One notable advantage of these macros is that they transparently define compiler and linker flags with distribution defaults.

cedeyn commented 10 months ago

Seems to properly fix #547

adammoody commented 10 months ago

Thank you, @rezib and @cedeyn .

adammoody commented 10 months ago

One more addition I see in https://github.com/hpc/mpifileutils/issues/547 is that it adds some build-time dependencies.

BuildRequires: cmake, libattr-devel, libarchive-devel, bzip2-devel, lustre-client-devel, openssl-devel

I'm guessing those are needed in clean build environments. Would adding those interfere with your build?

rezib commented 10 months ago

I'm guessing those are needed in clean build environments. Would adding those interfere with your build?

Absolutely not! We added these build requirements as well in our in-house spec file actually. We simply didn't contribute this change as we also include other build requirements that may not be relevant in the general case.

Thank you for the merge!