search

hpc / mpifileutils

File utilities designed for scalability and performance.
https://hpc.github.io/mpifileutils
BSD 3-Clause "New" or "Revised" License
168 stars 66 forks source link

dcp: Restore UID/GID after setting with --uid/--gid #586

Closed bdevcich closed 4 days ago

bdevcich commented 2 weeks ago

When --uid or --gid is used, MPI_Init() is called as the original user. The original uid/gid is not being restored prior to calling MPI_Finalize(), which leads to cleanup issues.

Resolves #585.

bdevcich commented 1 week ago

I'm not sure who I should ask to take a look so taking some guesses based on previous PRs: @ofaaland @gonsie

ofaaland commented 1 week ago

I'm not sure who I should ask to take a look so taking some guesses based on previous PRs: @ofaaland @gonsie

Thanks Blake, I'll look

bdevcich commented 1 week ago

Thanks @bdevcich for debugging this! I have just one nit.

It was my bug, so I felt obligated! 😄

ofaaland commented 1 week ago

Hi @bdevcich can you squash these commits and re-push? Thanks

bdevcich commented 1 week ago

@ofaaland done!

bdevcich commented 4 days ago

@ofaaland can you merge? I don't have permission to do so.

ofaaland commented 4 days ago

@ofaaland can you merge? I don't have permission to do so.

Odd, I thought I already had. I'll try again.

ofaaland commented 4 days ago

@bdevcich there you go. Thanks again!