search

hpc4cmb / toast

Time Ordered Astrophysics Scalable Tools
Other
44 stars 39 forks source link

NameError when applying common mode noise #661

Closed antolonappan closed 11 months ago

antolonappan commented 1 year ago

A NameError occurs when trying to generate common mode noise using the following code:

noise_model = ops.DefaultNoiseModel()
noise_model.apply(data)

common_mode_model = ops.CommonModeNoise(
            fmin=1e-5 * u.Hz,
            fknee=1.0 * u.Hz,
            alpha=2.0,
            NET=1.0 * u.K / u.Hz**0.5,
            det_data="corr_noise"
        )
common_mode_model.apply(data)

The error message shows:

NameError: name 'detset' is not defined
keskitalo commented 1 year ago

Thanks for the report! Can you confirm that the issue is with the toast3 branch?

@tskisner could this be related to the recent addition of observation sets?

antolonappan commented 1 year ago

Yes, this issue is with toast3 branch. Thanks.

giuspugl commented 1 year ago

I can reproduce the error, running with the latest version of toast in the toast3 branch. I will try to open a PR it 'd be easy to fix this.

keskitalo commented 11 months ago

Closing the issue with the fix merged.