hpcaitech / Open-Sora

Open-Sora: Democratizing Efficient Video Production for All
https://hpcaitech.github.io/Open-Sora/
Apache License 2.0
21.48k stars 2.06k forks source link

Bugfix: fix variable name and inference config. #374

Closed ArkiZh closed 3 months ago

ArkiZh commented 3 months ago
  1. Fix wrong variable name: enable_flashattn to enable_flash_attn.
  2. Fix model dtype: From default to bf16.
zhengzangw commented 3 months ago

Thank you for your PR. Your suggestion is valuable. However, we are now conducting a transformation of our model to huggingface's conversion. Thus, we will use another format and close your PR for now.

ArkiZh commented 3 months ago

Thank you for your PR. Your suggestion is valuable. However, we are now conducting a transformation of our model to huggingface's conversion. Thus, we will use another format and close your PR for now.

Really looking forward to the transition to the Hugging Face format, it's indeed a great move.