hpcc-systems / DataPatterns

HPCC Systems ECL bundle that provides some basic data profiling and research tools to an ECL programmer
3 stars 4 forks source link

BestRecordStructure Suggestion #21

Closed GordonSmith closed 5 years ago

GordonSmith commented 5 years ago

As part of the BestRecordStructure output, it would be nice if it included a second line with a a suitable transform function (especially for all the STRING -> REAL8 type conversions).

dcamper commented 5 years ago

The current version of BestRecordStructure returns a dataset, where every record is a "dataType fieldName;" declaration (wrapped by "RECORD" and "END" records) to make it relatively easy to copy and paste into an editor.

Adding another output means changing this function from returning a dataset to returning an action that outputs two datasets. Do you think this change would negatively impact many current users? The primary use case was not programmatic (e.g. the output is unlikely to consumed by other ECL code) but the possibility exists.

Thoughts?

GordonSmith commented 5 years ago

I would add more lines at the bottom that includes the transform + project? When copying users can easily ignore if not wanted?

dcamper commented 5 years ago

Ha! That is an excellent suggestion.

dcamper commented 5 years ago

Change just merged.