search

hpcc-systems / DataPatterns

HPCC Systems ECL bundle that provides some basic data profiling and research tools to an ECL programmer
3 stars 4 forks source link

chore(Report): Bump Viz Versions #71

Closed GordonSmith closed 3 years ago

GordonSmith commented 3 years ago

Signed-off-by: Gordon Smith GordonJSmith@gmail.com

GordonSmith commented 3 years ago

@dcamper - bumped all versions and cleaned up some of the loader code.

dcamper commented 3 years ago

@GordonSmith Why is .vscode now included?

GordonSmith commented 3 years ago

Its only used for Dev + Debug work (I had deleted the DataPatterns folder on my machine and had to recreate it, don't want to do it again)

GordonSmith commented 3 years ago

The only files from a runtime perspective are the ones in: https://github.com/hpcc-systems/DataPatterns/blob/master/Profile.manifest

dcamper commented 3 years ago

Well, in my dev environment DataPatterns is a subfolder and the parent folder is what is opened in VS Code. Wouldn't this embedded .vscode directory override some values found in the parent in that kind of configuration? I may be misremembering a problem I had at one time....

GordonSmith commented 3 years ago

@jeclrsg - had an elegant suggestion for this case (rename to launch.json.sample) I will do that.

@jeclrsg please review

dcamper commented 3 years ago

@GordonSmith The latest changes to .vscode make more sense. Thanks.

GordonSmith commented 3 years ago

@dcamper - tidied up the .vscode folder as per above comments.

dcamper commented 3 years ago

@GordonSmith Please target candidate-1.8.2 instead of master.