hpcc-systems / Tombolo

Apache License 2.0
5 stars 4 forks source link

Removed incorrectly implemented and non-functional print asset functionality. #854

Closed ydahal1 closed 2 weeks ago

ydahal1 commented 2 weeks ago

Description

Removed incorrectly implemented and non-functional print asset functionality. The original goal was to print asset-related data. This incorreclty implemented functionality attempts to generate the file directly from the DOM, which is not the correct method. The proper implementation would involve generating a PDF with asset details on the server and sending it to the client via res.sendFile

Fixes # (issue)

Type of change

Developer Checklist:

Reviewer Checklist

ydahal1 commented 2 weeks ago

Removed incorrectly implemented and non-functional print asset functionality. The original goal was to print asset-related data. This incorreclty implemented functionality attempts to generate the file directly from the DOM, which is not the correct method. The proper implementation would involve generating a PDF with asset details on the server and sending it to the client via res.sendFile

FancMa01 commented 2 weeks ago

Merge Conflict now, please fix