search

hpcc-systems / Visualization

HPCC JavaScript Framework
https://hpcc-systems.github.io/Visualization/
Other
93 stars 62 forks source link

Graph/Edge->points() type definition invalid #3139

Closed ghost closed 5 years ago

ghost commented 5 years ago

I believe the overloads for the points method of "Graph/Edge.ts" file is missing transitionDuration and skipPushMarkers

GordonSmith commented 5 years ago

I am looking at this: https://github.com/hpcc-systems/Visualization/blob/master/packages/graph/src/Edge.ts#L68-L77 They appear to be there?

Note: The points array is only used in hierarchy mode (its to route the edges around other nodes).

ghost commented 5 years ago

Yeah that's the spot!

It's being called from https://github.com/hpcc-systems/Visualization/blob/master/packages/graph/src/Graph.ts#L703. This is what I am mimicking after the layout finishes when I updating node positions. When I was not calling it the edges were being disconnected from the nodes. Is this not what I should be calling?

GordonSmith commented 5 years ago

I don't believe you should be setting points at all - if its undefined the edge will take the source/target vertex pos as its positioning. The only time its used, is with Hierarchy layout, where the layout specifically sets several points to "route" the edge around the nodes.

GordonSmith commented 5 years ago

@MattMckeller is this ok to close?

ghost commented 5 years ago

I don't see the type definitions as updated?

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.