search

hpcc-systems / Visualization

HPCC JavaScript Framework
https://hpcc-systems.github.io/Visualization/
Other
92 stars 62 forks source link

MultiChart Surface: C3 chart Legend overlaps the surface menu while switching between charts in Firefox browser #806

Closed gnansu closed 9 years ago

gnansu commented 9 years ago

The normal behavior of multichart surface is when we switch charts it blanks the surface (hides the chart and the legend) and once the new chart is selected, it renders the new chart. I'm seeing a different behavior in firefox browser. If the current chart is any C3 chart (line, column, bar) and when I click the surface menu, the legend, the chart axis does not hide. Hence the legend overlaps the menu.

This hinders the user from switching from C3 charts to any other chart.

When the current chart is any google chart, this does not happen. Everything is fine while using Google Chrome.

gnansu commented 9 years ago

Any updates on this?

mzummo commented 9 years ago

@GordonSmith Can we hack this so that showLegend(false) is set during menu render?

mzummo commented 9 years ago

@GordonSmith perhaps we can support a universal param that fires on the underlying widget for such kinds of events

GordonSmith commented 9 years ago

The showLegend(false) if its a C3 chart is what I was going to suggest doing.

gnansu commented 9 years ago

@mlzummo @GordonSmith thanks

GordonSmith commented 9 years ago

@mlzummo I am just testing this in master now and it seems that my fix does in fact work (the C3 legend is being hidden with the rest of the C3 chart:
http://rawgit.com/hpcc-systems/Visualization/master/demos/dermatology.html?src/chart/MultiChartSurface&chartType=C3_COLUMN (and turn on showLegend - then click on the menu in the surface title bar).

mzummo commented 9 years ago

@GordonSmith did you test this with FireFox the issue was only present there

GordonSmith commented 9 years ago

Ahh yes ok that makes sense... I notice that the C3 Axis doesn't get hidden either - gotta be a C3 issue I suspect.