hpcc-systems / vscode-ecl

ECL Extension for VSCode
https://marketplace.visualstudio.com/items?itemName=hpcc-systems.ecl
Other
13 stars 13 forks source link

feat: add refresh to the WU context menu #388

Closed dehilsterlexis closed 8 months ago

dehilsterlexis commented 8 months ago

fixes #386

dehilsterlexis commented 8 months ago

@GordonSmith for review. I removed passing the element to the refresh function so that when the user explicitly selects refresh, it forces a fresh. The reason being the way it is currently, the only time it refreshes is when it receives an event that is local. because it checks for any changes in the local tree. If you are listing workunits that are from other people that has changed, the refresh currently will not refresh because it is checking for a local change. I think the user expects refresh to force a refresh without condition.

ddehilster commented 8 months ago

@GordonSmith they both force a refresh. They call the same function. The httpsystems-refresh command is only called in those two places, so it won't change the behavior of other refresh calls.

GordonSmith commented 8 months ago

The one in the title should refresh the entire tree, while the one a WU should just refresh that node?

ddehilster commented 8 months ago

That makes sense. I will look into a way to pass the element without it checking if that element has changed. I need to force that one element. Will work on that.

dehilsterlexis commented 8 months ago

@GordonSmith the refresh forces an entire refresh only if the user instantiates the refresh manually. For review.

ddehilster commented 8 months ago

@GordonSmith for review

dehilsterlexis commented 8 months ago

@GordonSmith for review