CMakeLists Fixes - Githubissues

hpcgarage / spatter

Benchmark for measuring the performance of sparse and irregular memory access.

Other

75 stars 15 forks source link

CMakeLists Fixes #205

Closed jyoung3131 closed 3 months ago

jyoung3131 commented 3 months ago

Overview

Write an explanation of the PR's goal here.

✨ Change Description/Rationale

Update CMakeLists to remove the Release flag which is also specified in cmake/BuildType.cmake. Bump required version of CMake to include support for pulling in JSON tarball.
Closes #197

👀 Reviewer Checklist

[ ] All GitHub actions and runners have passed if applicable
[ ] Commits are clean and relevant

✅ PR Checklist

[x] Remove or update the template boilerplate text
[x] Commits are relevant and combined where appropriate
[x] Rebase off spatter-devel
[x] Reviewers Requested
[x] Projects associated
[x] Commits mention issue and/or PR numbers at the bottom of the message
[x] Relevant issues are linked into the PR
[x] TODOs are completed
[ ] Reviewer checklist is updated

🚀 TODOs

No additional Todos for this PR.

📌 Future Work

No additional future work

jyoung3131 commented 3 months ago

Looking at how long the CI tests took (20 versus 2 minutes), I think that the cmake/BuildType.cmake Release flag is not getting picked up...