Possible bug - memory usage MB displayed as KB

[GeorgeDewar]

When I type "stackato stats", I get the following:

+----------+-------------+-----------------+---------------+---------------------------+---------+---------------+ | Instance | CPU (Cores) | Memory (limit) | Disk (limit) | Started | Crashed | Uptime | +----------+-------------+-----------------+---------------+---------------------------+---------+---------------+ | 0 | RUNNING | 233.0K (512.0M) | 251.8M (2.0G) | 2014-01-27 13:09:27 -0800 | | 0d:0h:39m:52s | | 1 | RUNNING | 214.1K (512.0M) | 251.7M (2.0G) | 2014-01-28 10:09:27 +1300 | | 0d:0h:39m:49s | +----------+-------------+-----------------+---------------+---------------------------+---------+---------------+

The memory usage, as reported by the web console and likely to be correct, is actually more like 230MB per app.

Is this saying K when it means M?

[andreas-kupries]

Yes indeed. The code path for S3 has a regression, where it assumed that the returned memory information is in B, whereas the proper unit is KB.

See below for a patch fixing the issue.

diff --git a/lib/cmd/app.tcl b/lib/cmd/app.tcl index 696a511..3eff136 100644 --- a/lib/cmd/app.tcl +++ b/lib/cmd/app.tcl @@ -1641,7 +1641,7 @@ proc ::stackato::cmd::app::StatsV2 {config theapp} { set usage [dict get' $stats usage {}] if {$usage ne {}} { set started [dict get $usage time]

• set m [psz [dict get $usage mem]]
• set m [psz [expr {[dict get $usage mem] * 1024}]] set d [psz [dict get $usage disk]] } else { set started N/A

[GeorgeDewar]

Excellent, thank you. I think GitHub may have tried to apply some formatting to your patch, but in this case as we are only evaluating Stackato, we don't urgently need to fix it.

To clarify though, are you saying the fault is in fact in Stackato rather than the CLI?

[andreas-kupries]

The fault was in the CLI. The 3.0.4 release should have the fix.