search

hpcloud / tail

Go package for reading from continously updated files (tail -f)
MIT License
2.71k stars 503 forks source link

Revert "Tailing stop bug fix" #110

Closed Nino-K closed 7 years ago

Nino-K commented 7 years ago

Reverts hpcloud/tail#99

TerraTech commented 7 years ago

@Nino-K Did this patch go sideways with a test?

Nino-K commented 7 years ago

@TerraTech yes, broke the build initially and had to revert it, but it's merged now and the build is green.

arunmathew88 commented 7 years ago

@Nino-K So as of now hpcloud/tail#99 is merged and there is no problem?

Nino-K commented 7 years ago

@arunmathew88 thanks for your contribution. So far so good, I tested it myself and did not come across any issues. The test coverage in this project is pretty low, I will have to through some tests in there to cover some of these cases.

arunmathew88 commented 7 years ago

Thanks @Nino-K .