hpcloud / tail

Go package for reading from continously updated files (tail -f)
MIT License
2.72k stars 505 forks source link

fsnotify dependency broken #136

Closed mattayes closed 6 years ago

mattayes commented 6 years ago

The import used for fsnotify (gopkg.in/fsnotify.v1) no longer points to the correct repository. Someone created go-fsnotify/fsnotify which broke an old redirect to the real fsnotify. Anyone using gopkg.in/fsnotify.v1 or github.com/go-fsnotify/fsnotify will get the squatted (incorrect) package.

This isn't an issue if you're using tail directly, since fsnotify is vendored. However, when using tail with a dependency manager (we use dep), things break.

I recommend changing the import used in watch/inotify_tracker.go from gopkg.in/fsnotify.v1 to github.com/fsnotify/fsnotify as recommended by the fsnotify docs.

I'm happy to create a PR for this, if you'd like.

mattayes commented 6 years ago

Closed with #138.