Closed promiseofcake closed 6 years ago
Fixes #136
@Nino-K can we merge this PR asap ? the build is now broken, we can't deliver the release and the CI is not working now...
any news on that merge? Really need this to release ....
@idanya, @c9s, depending on your build system you should be able to use the pre-merge commit from our public fork by modifying your repo
param (glide), source
override (dep) or something similar for other package tools, ie for Bazel:
go_repository(
name = "com_github_hpcloud_tail",
importpath = "github.com/hpcloud/tail",
remote = "git@github.com:vsco/tail.git",
vcs = "git",
commit = "000912af8de2d2b9d184786b4cf4c3542b7884e5"
)
Yes, I'm using govendor and already did the same (forked and merged your commit). I'd rather it be merged here but I guess that will do for now :\
Please merge.... it's totally broken now
If you're using dep, add the following to your Gopkg.toml
:
[[override]]
name = "github.com/hpcloud/tail"
source = "https://github.com/vsco/tail.git"
revision = "000912af8de2d2b9d184786b4cf4c3542b7884e5"
@florindragos Are you the only person with write-access to this project?
@promiseofcake The fsnotify
project prefers github.com/fsnotify/fsnotify
to the gopkg.in
link: https://godoc.org/github.com/fsnotify/fsnotify.
@mattayes, thanks for the link. In order to not conflate changes, I would be more than happy to make that change once we get this merged in.
+1 on this merging. This is blocking a few deployments.
any update?
@Nino-K do you still have write access to this repo/time to review this?
This is a key blocker right now. Any estimate on when it can be merged?
This also blocks use of hpcloud/tail with vgo (at least I've been unable to get it working)
@sergei-utinski, do you know anyone who can help us out?
Thanks @sergei-utinski! What are the plans for this repo? Can community members get write access, or should we look into housing this repo somewhere else?
The https://github.com/go-fsnotify/fsnotify redirect has been disabled and replaced with an empty repo, the new path for gopkg.in is: http://gopkg.in/fsnotify/fsnotify.v1 as of yesterday.
fsnotify
import paths to: gopkg.in/fsnotify/fsnotify.v1vendor/fsnotify.v1
to the new import path