search

hpcloud / tail

Go package for reading from continously updated files (tail -f)
MIT License
2.7k stars 502 forks source link

fsnotify has moved away from gopkg.in #168

Open matzhouse opened 4 years ago

matzhouse commented 4 years ago

Hi,

There's an issue with importing fsnotify using gopkg.in/fsnotify.v1

They have moved away from gopkg.in but have released a new version that is causing issues. (It should be imported using the github url btw)

See https://github.com/fsnotify/fsnotify/issues/328

Because you have referenced the gopkg.in version in your imports it's causing anything that is importing your code and using modules to break.

go get: upgrading gopkg.in/fsnotify.v1@v1.4.7: gopkg.in/fsnotify.v1@v1.4.8: invalid version: go.mod has non-....v1 module path "github.com/fsnotify/fsnotify" at revision v1.4.8
ERROR: Service 'ginkgo-base' failed to build: The command '/bin/sh -c go get -u github.com/onsi/ginkgo/ginkgo && go get -u github.com/onsi/gomega/... && export PATH=$PATH:$HOME/gopath/bin' returned a non-zero code: 1

There's not really any blame here, I'm just giving you a heads up as i'm sure others might find problems with this!

flyhard commented 4 years ago

I noticed that https://github.com/nxadm/tail has already fixed this in his repo - and many more issues.