search

hpcugent / vsc-base

Basic Python libraries used by UGent's HPC group
Other
14 stars 51 forks source link

add support for CC and BCC in sendTextMail and sendHTMLMail #316

Closed smoors closed 3 years ago

stdweird commented 3 years ago

i'm not a fan of more strings that are lists. you can make the to_mail and esp the new cc and bcc lists. only for to_mail you should support the (as of now) deprecated behaviour that a single email addr as a string is passed.

smoors commented 3 years ago

@stdweird thanks for the review. I prefer lists as well, was mainly concerned about not breaking stuff at your side and consistency.

smoors commented 3 years ago

ping?

stdweird commented 3 years ago

@smoors minor remakrs. next time this code is touched, we will need to refactor inseatd of copy/pasting identical code