search

hpcugent / vsc-base

Basic Python libraries used by UGent's HPC group
Other
14 stars 51 forks source link

p39: disable empty logging tests #344

Closed wdpypere closed 11 months ago

wdpypere commented 11 months ago

It seems that around python 3.7 log stream handling was changed. (can't find the actual change in the changelog)

I believe this is a good thing as now "logging with logging" no longer disappears when using fancylogger, which used to happen.

We used to test specifically for this behaviour. How big the behaviour change is, I can't say. So I don't know if we should rework fancylogger or just disable the test. As I would like to get rid of fancylogger I would propose to just disable the test, as this "new" behaviour might make migrating away from facylogger easier.

but those are just my 50 cents.

wdpypere commented 11 months ago

@stdweird this is not urgent at all, but at some point in the future I would like your opinion on this.

wdpypere commented 11 months ago

@stdweird remark addresses

wdpypere commented 11 months ago

@stdweird fixed