search

hpcugent / vsc-mympirun

mympirun is a tool to facilitate running MPI programs on an HPC cluster
GNU General Public License v2.0
6 stars 9 forks source link

fix --hybrid when using (recent) OpenMPI #175

Closed boegel closed 4 years ago

boegel commented 4 years ago

fixes #174

stdweird commented 4 years ago

@boegel looks ok, buttests fail

boegel commented 4 years ago

Seems like one of the tests hardcodes a particular order, which isn't always preserved?

======================================================================
FAIL: test_openmpi4 (test.end2end.TestEnd2End)
Test dry run with OpenMPI 4.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/hpcugent_github.com/jobs/vsc-mympirun/branches/PR-175/workspace/test/end2end.py", line 504, in test_openmpi4
    self.assertTrue(regex.search(out), "Pattern '%s' should be found in: %s" % (regex.pattern, out))
AssertionError: None is not true : Pattern '^fake mpirun called with args:.*--mca pml ucx --mca btl \^uct' should be found in: fake mpirun called with args: -machinefile /tmp/tmpSXf3v8/.mympirun_aye8x3/12345_20201106_224538/nodes --mca orte_keep_fqdn_hostnames 1 --mca btl ^uct --mca MKL_NUM_THREADS 1 --mca pml ucx -np 2 -x PATH -x PYTHONPATH -x OMP_NUM_THREADS mpi_hello
stdweird commented 4 years ago

@boegel well, you did change a super invocation, so maybe that part messes some stuff around?

boegel commented 4 years ago

@stdweird Fixed.