search

hpe-storage / co-deployments

HPE storage platforms deployment declarations for container orchestrators
https://scod.hpedev.io
Apache License 2.0
11 stars 47 forks source link

Use digests instead of tags #231

Closed ondrejlinha closed 3 months ago

ondrejlinha commented 3 years ago

Hello,

Would it be possible to start using image SHA digests instead of tags since tags for 'ImageContentSourcePolicy' resources are no longer supported by Red Hat[1]?

Using tags makes the whole operator unusable in OpenShift 4 disconnected environments[2][3].

If you need I can prepare a PR for the next release.

[1] https://access.redhat.com/solutions/4817401 [2] https://github.com/openshift/api/issues/636 [3] https://github.com/openshift/okd/issues/226

Cheers, Ondrej

datamattsson commented 3 years ago

Using tags makes the whole operator unusable in OpenShift 4 disconnected environments[2][3].

We added a "registry" parameter to allow pulling images from an internal registry for air-gapped installs.

Sifting through your provided links (thanks!) I can see that "registry" won't be very helpful in those scenarios. Let me bring this up with product management.

datamattsson commented 6 months ago

We've switched to pulling by digest. Can you please confirm with v2.4.2 of the Operator?