hpe-storage / csi-driver

A Container Storage Interface (CSI) driver from HPE
https://scod.hpedev.io
Apache License 2.0
57 stars 53 forks source link

Additional vendoring #329

Closed datamattsson closed 1 year ago

datamattsson commented 1 year ago

Signed-off-by: Michael Mattsson michael.mattsson@gmail.com

datamattsson commented 1 year ago

There's some issue when pulling in common-host-libs and k8s-custom-resources, those can be manually fixed before building though but we should cut new tags on those repos I assume.

raunakkumar commented 1 year ago

There's some issue when pulling in common-host-libs and k8s-custom-resources, those can be manually fixed before building though but we should cut new tags on those repos I assume.

Sure. Common host libs still doesn't use go.mod but an older vendoring mechanism glide (prior to go 1.12 when go.mod became default) We had intern convert it to go.mod https://github.com/hpe-storage/common-host-libs/pull/164 and that maybe needed if we need parity.