hpe-storage / csi-driver

A Container Storage Interface (CSI) driver from HPE
https://scod.hpedev.io
Apache License 2.0
58 stars 53 forks source link

Update building instructions #339

Closed krakazyabra closed 1 year ago

krakazyabra commented 1 year ago

Hi!

Please, update building instructions:

make: [Makefile:70: clean] Error 1 (ignored)
Running lint
go version go1.15.15 linux/arm64
export PATH=$PATH:/root/go/bin && golangci-lint run --disable-all --enable=vet --enable=vetshadow --enable=golint --enable=ineffassign --enable=goconst --enable=deadcode --enable=dupl --enable=varcheck --enable=gocyclo --enable=misspell --deadline=240s --exclude vendor
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] Can't run linter goanalysis_metalinter: inspect: failed to load package csi: could not load export data: no export data for "github.com/container-storage-interface/spec/lib/go/csi"
ERRO Running error: 1 error occurred:
    * can't run linter goanalysis_metalinter: inspect: failed to load package csi: could not load export data: no export data for "github.com/container-storage-interface/spec/lib/go/csi"

make: *** [Makefile:63: lint] Error 3

Tried to build driver on

root@arm1:~/csi-driver# go version
go version go1.15.15 linux/arm64
root@arm1:~/csi-driver# $GOPATH/bin/golangci-lint --version
golangci-lint has version 1.52.2 built with go1.20.2 from da04413a on 2023-03-25T18:11:28Z

Also, can you, please, explain, why did you predefined architecture here: https://github.com/hpe-storage/csi-driver/blob/master/Makefile#L8

Are there any problems building for ARM arch?

krakazyabra commented 1 year ago

Sry, my fault, too old go version, updated to

root@arm1:~# go version
go version go1.20.3 linux/arm64

And everything went as expected