search

hpe-storage / csi-driver

A Container Storage Interface (CSI) driver from HPE
https://scod.hpedev.io
Apache License 2.0
58 stars 53 forks source link

Bug/ con 2960 #347

Closed sijeesh closed 1 year ago

sijeesh commented 1 year ago

Added a new flag "DISABLE_NODE_CONFIGURATION" to disable the node configuration(like package installation,multipath, iscsi,etc.) completely.

sijeesh commented 1 year ago

I'm not loving the inconsistency in the expressions we've bestowed upon us in this file.

if [ "$arg" = "--node-service" ]; then
if [ "$nodeservice" = true ]; then
if [ "${DISABLE_NODE_CONFORMANCE}" = "true" ]; then

Can we also change configureNode to configurenode for consistency? Updated entry script to have only camel case variables. Also moved environment variables top to improve readability.